#Another layer of indirection code#

Client code which places an explicit reference in a declaration with auto specifier.Ĭonst auto &wd = get_working_directory() // C26445 after API update. The problem could be hidden in this huge multilayer cake of indirection. Indirection can make things harder to understand and hide problems. Std::string_view get_working_directory() noexcept Any problem can be solved with another layer of indirection. New API – after migration to C++17 it uses string view. In such cases, false positives can safely be suppressed.Įxample: Reference to a temporary // Old API - uses string reference to avoid data copy.Ĭonst std::string& get_working_directory() noexcept In programming, a good example is the difference in details between machine code and the various tools for creating applications that are ultimately based on machine code. Abstraction is a mechanism that 'hides' complicated details of a object in terms of simpler, easier to manipulate terms. Using of references may still make sense in some scenarios. Abstraction deals with simplification, indirection deals with location. The implementation of this rule is lightweight doesn't attempt to trace actual lifetimes.This rule may be extended in future to also flag function parameters. Currently warnings are emitted only on declarations and return statements.The rule detects references to gsl::span, gsl::basic_string_span, and std::basic_string_view (including aliases to instantiations).Obviously, such call results should never be referenced. Data mappers act as a single location for object transformations. Spans are cheap to copy and can be returned by value from function calls. The DTOs act as a layer of indirection and shield the clients from internal changes to the way the API is resolved.

Such indirection is often unnecessary and can be confusing for maintainers. Such types can be considered as 'references to buffers.' Using a reference to a span or view creates an additional layer of indirection.

This rule catches subtle lifetime issues that may occur in code migrated from standard containers to new span and view types. A reference to gsl::span or std::string_view may be an indication of a lifetime issue.

Another layer of indirection